Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @types/big.js to devDependencies #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move @types/big.js to devDependencies #148

wants to merge 1 commit into from

Conversation

valamidev
Copy link

@valamidev valamidev commented Jun 19, 2022 •
edited
Loading

  • @types are only required for Typescript build

@vercel
Copy link

vercel bot commented Jun 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
essential-eth ✅ Ready (Inspect) Visit Preview Jun 19, 2022 at 9:36AM (UTC)

@dawsbot
Copy link
Owner

dawsbot commented Jun 23, 2022 •
edited
Loading

Good PR @valamidev 🙏

I recall at one point a few months ago I tried this and the production TS build broke in the "parent" application which consumed essential-eth.

I will try this out locally behind a beta-tag version in npm and report progress here 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valamidev @dawsbot